Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35071: Add support for datasets using old Gen 3 registry versions. #161

Merged
merged 1 commit into from Jun 2, 2022

Conversation

kfindeisen
Copy link
Member

This PR allows ap_verify to read datasets whose preloaded repo has a registry version other than the latest. This solution involves using an unsafe keyword for RawIngestTask, but avoids dataset churn.

This fix is not unit tested, since ap_verify_testdata does not have solar system data and therefore does not export exposure records.

@kfindeisen kfindeisen requested a review from timj June 2, 2022 18:39
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me.

@kfindeisen kfindeisen merged commit fbbcda8 into main Jun 2, 2022
@kfindeisen kfindeisen deleted the tickets/DM-35071 branch June 2, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants