Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-36743: Add the real-bogus PipelineTask to ap_verify for the DC2 CI dataset #174

Merged
merged 6 commits into from May 9, 2023

Conversation

NimSed
Copy link
Contributor

@NimSed NimSed commented Nov 24, 2022

plugged rbClassify into dc2 ap_verify

@kfindeisen kfindeisen changed the title tickets/DM-36743 DM-36743: Add the real-bogus PipelineTask to ap_verify for the DC2 CI dataset Nov 28, 2022
@NimSed
Copy link
Contributor Author

NimSed commented Jan 25, 2023

@kfindeisen, the model package is now stored in the neighboring package (rbClassify_data). Here's the relevant PR:
lsst-dm/rbClassifier_data#1

Although I still don't think the problem with the nightly builds is fully resolved, according to the discussions and decisions under https://jira.lsstcorp.org/browse/DM-37478 this is the solution we want to go ahead with (and it is less hacky at least).

Please let me know if there are any more points.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we still need to get the supporting infrastructure in place before this can be merged.

(Also, note that @isullivan is the reviewer of record -- I'm just heckling, so my opinion doesn't count 😉)

pipelines/LSSTCam-imSim/ApVerifyWithFakes.yaml Outdated Show resolved Hide resolved
pipelines/LSSTCam-imSim/ApVerify.yaml Outdated Show resolved Hide resolved
@NimSed
Copy link
Contributor Author

NimSed commented Apr 17, 2023

@kfindeisen please check and see whether the issue you've mentioned here is resolved.
Did you catch it in the usual pytest tests, or when running it through jenkins?

@kfindeisen
Copy link
Member

Yes, that looks like the current TransiNetConfig API. No, I did not try to run any tests -- what would have been the point?

@NimSed NimSed merged commit bacb4da into main May 9, 2023
1 check passed
@NimSed NimSed deleted the tickets/DM-36743 branch May 9, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants