Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35207: Reset visitSummary connections after upstream DRP-focused changes. #176

Merged
merged 1 commit into from Jan 11, 2023

Conversation

TallJimbo
Copy link
Member

No description provided.

@laurenam
Copy link
Contributor

@kfindeisen, could I ask you to approve this one once you’re satisfied?

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long as the config overrides at

# Conversion of fakes_visitSummary [visit-level afw.table] to fakes_visitTable [instrument-level Parquet]
makeVisitTable:
class: lsst.pipe.tasks.postprocess.MakeVisitTableTask
config:
connections.calexpType: parameters.fakesType
# Conversion of fakes_visitSummary [visit-level afw.table] to fakes_ccdVisitTable [instrument-level Parquet]
makeCcdVisitTable:
class: lsst.pipe.tasks.postprocess.MakeCcdVisitTableTask
config:
connections.calexpType: parameters.fakesType
are appended to those in Conversions.yaml instead of overwriting them (I always forget when that happens), I think this is fine.

@TallJimbo TallJimbo merged commit d4a5d01 into main Jan 11, 2023
@TallJimbo TallJimbo deleted the tickets/DM-35207 branch January 11, 2023 18:35
@TallJimbo TallJimbo restored the tickets/DM-35207 branch January 18, 2023 03:42
@TallJimbo TallJimbo deleted the tickets/DM-35207 branch January 18, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants