Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-39605: Use butler.dimensions rather than butler.registry.dimensions #189

Merged
merged 1 commit into from Jun 9, 2023
Merged

DM-39605: Use butler.dimensions rather than butler.registry.dimensions #189

merged 1 commit into from Jun 9, 2023

Conversation

timj
Copy link
Member

@timj timj commented Jun 8, 2023

The latter will be deprecated in the future.

@timj
Use butler.dimensions rather than butler.registry.dimensions
6410a12 
The latter will be deprecated in the future.
@timj timj requested a review from kfindeisen June 8, 2023 22:02
kfindeisen
kfindeisen approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "will be deprecated in the future" is reasonable grounds for removal, but I have no objections to the change itself.

@timj
Copy link
Member Author

timj commented Jun 9, 2023

We want people to use butler.dimensions because in a few months that will be the only way to do it. I'm getting ahead of things. There is no active deprecation for butler.registry.dimensions at the moment because sometimes people only have a Registry object but if they are starting from butler we want them to do it this way and there is no harm in doing it this way now.

@timj timj merged commit b76218d into main Jun 9, 2023
1 check passed
@timj timj deleted the tickets/DM-39605-ap_verify branch June 9, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@timj @kfindeisen