Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-39411: Add timing metrics for remaining AP pipeline tasks #199

Merged
merged 1 commit into from Aug 31, 2023

Conversation

kherner
Copy link
Contributor

@kherner kherner commented Aug 24, 2023

No description provided.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing entries look good (aside from the MapDiaSourceTime vs. TransformDiaSourceCatalogTime question), but please also add the CpuTime metrics so that we have the data in case we ever want it.

pipelines/_ingredients/MetricsRuntime.yaml Outdated Show resolved Hide resolved
pipelines/_ingredients/MetricsRuntime.yaml Outdated Show resolved Hide resolved
pipelines/_ingredients/MetricsRuntime.yaml Show resolved Hide resolved
@kherner kherner force-pushed the tickets/DM-39411 branch 2 times, most recently from 642d1fa to e0bf70b Compare August 31, 2023 00:52
@kherner
Copy link
Contributor Author

kherner commented Aug 31, 2023

Changes are done if you want to look again before I merge.

Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are out of sync with lsst/verify_metrics#40, but that's a simple enough fix.

pipelines/_ingredients/MetricsRuntime.yaml Outdated Show resolved Hide resolved
pipelines/_ingredients/MetricsRuntime.yaml Outdated Show resolved Hide resolved
Added wall time and cpu time metrics for retrieveTemplate and rbClassify
@kherner kherner merged commit ab270fa into main Aug 31, 2023
2 checks passed
@kherner kherner deleted the tickets/DM-39411 branch August 31, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants