New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-38247: Use long-log for ap_verify runs #207

Merged

parejkoj merged 2 commits into main from tickets/DM-38247

Dec 4, 2023

Contributor

parejkoj commented Dec 4, 2023

{Summary of changes. Prefix PR title with JIRA issue.}

Do unit tests pass (scons and/or stack-os-matrix)?
Did you run ap_verify.py on at least one of the standard datasets?
For changes to metrics, the print_metricvalues script from lsst.verify will be useful.
Is the Sphinx documentation up-to-date?


          Use long-log for ap_verify runs

7d80192

kfindeisen approved these changes

View reviewed changes

python/lsst/ap/verify/pipeline_driver.py

@@ @@ -94,7 +94,7 @@ def runApPipeGen3(workspace, parsedCmdLine, processes=1): @@
                   makeApdb(_getApdbArguments(workspace, parsedCmdLine))
                   pipelineFile = _getPipelineFile(workspace, parsedCmdLine)
-                  pipelineArgs = ["pipetask", "run",
+                  pipelineArgs = ["pipetask", "--long-log", "run",
                                   "--fail-fast",

Member

kfindeisen Dec 4, 2023

Preexisting, but can you add a comment that --fail-fast is to compensate for the extra interconnections added by --graph-fixup?


          Add note about the rationale for fail-fast

parejkoj merged commit b346346 into main

2 checks passed

parejkoj deleted the tickets/DM-38247 branch

December 4, 2023 22:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment