Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-40798: Exclude sky sources from RB classification #210

Merged
merged 1 commit into from Feb 7, 2024
Merged

DM-40798: Exclude sky sources from RB classification #210

merged 1 commit into from Feb 7, 2024

Conversation

rai-harshit
Copy link
Contributor

@rai-harshit rai-harshit commented Jan 29, 2024 •
edited

{Summary of changes. Prefix PR title with JIRA issue.}

  • Do unit tests pass (scons and/or stack-os-matrix)?
  • Did you run ap_verify.py on at least one of the standard datasets?
    For changes to metrics, the print_metricvalues script from lsst.verify will be useful.
  • Is the Sphinx documentation up-to-date?

@rai-harshit rai-harshit force-pushed the tickets/DM-40798 branch 4 times, most recently from 00abfbf to 1071cb2 Compare February 2, 2024 17:28
isullivan
isullivan approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@isullivan isullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One trivial import order comment.

python/lsst/ap/verify/testPipeline.py Outdated Show resolved Hide resolved
@rai-harshit rai-harshit force-pushed the tickets/DM-40798 branch 2 times, most recently from f2f934a to b2a4a1e Compare February 6, 2024 22:30
@rai-harshit rai-harshit merged commit 99595d6 into main Feb 7, 2024
2 checks passed
@rai-harshit rai-harshit deleted the tickets/DM-40798 branch February 7, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isullivan isullivan isullivan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rai-harshit @isullivan