Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-40400: Create total AP pipeline timing metric #216

Merged
merged 1 commit into from Mar 9, 2024

Conversation

kfindeisen
Copy link
Member

This PR adds the timing metric introduced on lsst/ap_pipe#168 to the standard runtime metrics for ApVerify. Like all timing metrics, it is not run on ApVerifyWithFakes.


  • Do unit tests pass (scons and/or stack-os-matrix)?
  • Did you run ap_verify.py on at least one of the standard datasets?
    For changes to metrics, the print_metricvalues script from lsst.verify will be useful.
  • Is the Sphinx documentation up-to-date?

This metric calculates the total wall-clock time for the pipeline,
assuming ISR is run first and DiaPipelineTask is run last. Since metric
tasks may run at any point, some variance is expected.
@kfindeisen kfindeisen requested a review from parejkoj March 7, 2024 22:58
Copy link
Contributor

@parejkoj parejkoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise this makes the use of the new metric quite clear.

connections.package: ap_pipe
connections.metric: ApPipelineTime
connections.labelStart: isr
connections.labelEnd: diaPipe
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth a comment here that diaPipe is what sends the alerts, and thus is the endpoint of our runtime requirement? That might not be obvious to someone reading, especially if our pipeline grows some post-diaPipe afterburners.

We may also implement some things in diaPipe after packageAlerts (writing detectorVisitProcessingSummary comes to mind) so it's always going to be an upper-bound on the runtime.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think alerts are particularly relevant here. It's simply the last task in the "bare" AP pipeline (though quite a few metrics depend on diaPipe outputs).

Copy link
Member Author

@kfindeisen kfindeisen Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, this metric is pretty much irrelevant for "our runtime requirement", because the batch processing environment is completely different from the prompt one. Based on my experiments with the three ap_verify datasets, a good chunk of the time measured by this metric is time spent running other data IDs' tasks.

@kfindeisen kfindeisen merged commit d40764c into main Mar 9, 2024
2 checks passed
@kfindeisen kfindeisen deleted the tickets/DM-40400 branch March 9, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants