Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-14496: test_association broken #30

Merged
merged 3 commits into from May 18, 2018
Merged

DM-14496: test_association broken #30

merged 3 commits into from May 18, 2018

Conversation

morriscb
Copy link
Contributor

No description provided.

kfindeisen
kfindeisen approved these changes May 17, 2018
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit surprised you never use indexerIds or associatedIds, but I guess if it works I can't complain.

@morriscb
Copy link
Contributor Author

I use them in some of the tests for ap_association. The function there is a direct copy-paste from those tests. I can remove those variables if you would like.

@morriscb morriscb merged commit 96af670 into master May 18, 2018
@kfindeisen kfindeisen deleted the tickets/DM-14496 branch November 30, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@morriscb @kfindeisen