Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-14557: Add package docs to datasets #35

Merged
merged 4 commits into from Jun 19, 2018
Merged

Conversation

kfindeisen
Copy link
Member

This PR makes some miscellaneous updates to the dataset docs in ap_verify. No link needed to be added to the documentation introduced in lsst-dm/legacy-ap_verify_hits2015#7, as broken links to the ap_verify_hits2015-package label were already present.

@kfindeisen kfindeisen requested a review from mrawls June 11, 2018 22:42
@@ -14,7 +14,7 @@ Repository
https://github.com/lsst-dm/ap_verify

Jira component
`ap_verify <https://jira.lsstcorp.org/issues/?jql=project %3D DM AND component %3D ap_verify>`_
`ap_verify <https://jira.lsstcorp.org/issues/?jql=project %3D DM %20AND%20 component %3D ap_verify>`_
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrawls it turns out I wasn't quite right in recommending spaces in URLs -- browsers can handle spaces, but Sphinx deletes them when writing the HTML.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well there's a fun mess. There may be a broken link lurking in ap_pipe too, then, but I'm not going to lose sleep over it.

@@ -14,7 +14,7 @@ Repository
https://github.com/lsst-dm/ap_verify

Jira component
`ap_verify <https://jira.lsstcorp.org/issues/?jql=project %3D DM AND component %3D ap_verify>`_
`ap_verify <https://jira.lsstcorp.org/issues/?jql=project %3D DM %20AND%20 component %3D ap_verify>`_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well there's a fun mess. There may be a broken link lurking in ap_pipe too, then, but I'm not going to lose sleep over it.

@@ -28,12 +28,26 @@ Organizing the Data

* The :file:`raw` and :file:`calib` directories contain science and calibration data, respectively.
The directories may have any internal structure.
* The :file:`templates` directory contains an :ref:`LSST Butler repository<butler>` containing processed images useable as templates.
* The :file:`templates` directory contains an :ref:`LSST Butler repository<butler>` containing processed images usable as templates.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FUN FACT: both usable and useable are acceptable spellings! (I don't have a preference 😆 ) https://english.stackexchange.com/questions/69709/is-useable-preferred-in-certain-regions-or-just-an-alternate-spelling-of-usa

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, my spellchecker disagrees. 🙂

The dataset's package-level documentation should include:

* the source of the data (e.g., a particular survey with specific cuts applied)
* whether or not optional files such as templates are provided
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Template" may be a bit overloaded here. Clarify that you mean coadds and/or visits (i.e., template images) for difference imaging when you say templates, please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Image differencing templates"?

@kfindeisen kfindeisen merged commit 1cec3bd into master Jun 19, 2018
@kfindeisen kfindeisen deleted the tickets/DM-14557 branch November 30, 2018 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants