DM-15096: Cannot reuse association database with ApPipeTask reruns #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriscb
approved these changes
Aug 1, 2018
kfindeisen
force-pushed
the
tickets/DM-15096
branch
from
53f1398
to
e958d38
Compare
I had thought calls using _getConfig were slow because they triggered an expensive copy in the ApPipeTask constructor. Instead, _getConfig is slow because Config construction is slow.
kfindeisen
force-pushed
the
tickets/DM-15096
branch
from
e958d38
to
1fa3f98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the association database an explicit part of the
ap_verifyworkspace. It also fills theApPipeConfigas required by lsst/ap_pipe#29.