DM-14849: Metadata-based metrics not measured #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The task name was previously hardcoded into metadata lookups despite an argument being available.
The old names were incorrect once ap_pipe became a CmdLineTask with subtasks.
This change allows measurements.measureRuntime to work with tasks that use run, runDataRef, or both.
ebellm
approved these changes
Aug 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a systematic error in the metadata keys being used by the
ap.verify.measurementspackage (the keys did not get updated whenap_pipewas turned into a task). It also broadens the runtime measurer for forward-compatibility with DM-2639.