DM-15901: Access metadata exclusively through Butler #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriscb
approved these changes
Nov 30, 2018
This change eliminates the need for code outside `measurements` to keep track of the metadata at all.
This code was a vestige of when ap_pipe was not itself a Task, and individual tasks' metadata stopped being used long ago.
kfindeisen
force-pushed
the
tickets/DM-15901
branch
from
3d3bb33
to
0c57f67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR treats metadata-based metrics as a special case of Butler-based metrics, removing
measureFromMetadatafrom themeasurementspackage's API. It also removes a lot of the vestigial infrastructure that was originally created to juggle metadata, greatly simplifyingpipeline_driver.pipeline_driverstill uses metadata as a workaround for the lack of Butler support inlsst.verify.Job; it may be possible to remove this at a later date.