DM-17248: ap_verify should create .json files in the workspace by default #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
reviewed
Mar 23, 2019
There was a problem hiding this comment.
This looks good, and I'm very happy to have the ap_verify output files land in the output repo. Please explain why the OptionalFormatDict is necessary; at a glance it seems to make it a bit overly complex but I suspect you use it to avoid a weird situation I'm just not seeing.
The new behavior is implemented through a template in --metrics-file, so scripts that redirect output won't see surprising changes.
kfindeisen
force-pushed
the
tickets/DM-17248
branch
from
b5d62ae
to
b0dcdfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the default location of
ap_verify's outputJobfiles to the workspace created by--output. This change is backwards-compatible with scripts that explicitly assign a location.