DM-20570: Pipeline failure treated as ap_verify success #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrawls
approved these changes
Aug 7, 2019
kfindeisen
commented
Aug 7, 2019
kfindeisen
force-pushed
the
tickets/DM-20570
branch
from
ac9dc5e
to
c153efd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propagates pipeline status information from the
ApPipeTaskwrapper to the main function, where it can be returned to the shell as if for a command-line task. This fixes a bug whereap_verify.pywould return 0 after catastrophic pipeline failure and the Jenkins run would be marked as successful.I think
ap_verify's exit code is correctly propagated fromrun_ci_dataset.shup to Jenkins, but I'm not sure how to test that. 馃槙