DM-24324: Generate alert packets in the alert production pipeline #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenczar
approved these changes
May 8, 2020
kfindeisen
reviewed
May 8, 2020
| @@ -132,5 +132,7 @@ def _getConfigArguments(workspace): | |||
| # ApVerify will use the sqlite hooks for the Apdb. | |||
| args.extend(["--config", "diaPipe.apdb.db_url=sqlite:///" + workspace.dbLocation]) | |||
| args.extend(["--config", "diaPipe.apdb.isolation_level=READ_UNCOMMITTED"]) | |||
| # Put output alerts into the workspace. | |||
| args.extend(["--config", "diaPipe.alertPackager.alertWriteLocation=" + workspace.outputRepo + "/alerts"]) | |||
There was a problem hiding this comment.
Not sure I like having this command-line config override (see my comment in ap_association).
If the alert output is here to stay and it's not supposed to be part of the repository, please consider handling it the same way as replacing workspace.dbLocation instead of putting it in the repository (or at leastworkspace.outputRepo with workspace.workDir, if you don't want to edit . If nothing else, it will be more compatible with Gen 3.Workspace)
Fix linting. Change to workDir.
morriscb
force-pushed
the
tickets/DM-24324
branch
from
94ec97f
to
f664f43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.