DM-24844: Migrate ap_verify_testdata to obs_lsst #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap_verify_testdata previously used obs_test.
kfindeisen
force-pushed
the
tickets/DM-24844
branch
from
c1478d7
to
81c1e33
Compare
This change required replacing a lot of obs_test references with testdata_lsst.
kfindeisen
force-pushed
the
tickets/DM-24844
branch
from
81c1e33
to
3ccec41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all unit tests to use
ap_verify_testdatainstead ofobs_test(the ingestion tests rely heavily on details of the specific files in the dataset, and had to be rewritten almost entirely). It also fixes several bugs revealed by the use of ImSim datasets.