DM-12432: Fix timing measurement construction #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old configuration broke the Policy class, because Policies are not allowed to have keys with dots yet perform no input validation.
kfindeisen
force-pushed
the
tickets/DM-12432
branch
from
caa81a5
to
7ab0e0f
Compare
jdswinbank
approved these changes
Nov 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ap_verifywas not creating measurements because the old config format violated the rules forPolicy, causing the config object to silently fail (this unhelpful behavior has been reported as DM-12559). The config format has been altered so that keys are guaranteed to not contain periods.