DM-20922: ap_verify can't handle --id with empty argument #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
approved these changes
Jul 8, 2020
This API change will make ap_verify.py less confusing for users familiar with command line tasks, where --id (with or without arguments) is mandatory to do any processing.
kfindeisen
force-pushed
the
tickets/DM-20922
branch
from
30ef6ed
to
c19ae55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets callers of
ap_verify.pyuse--idby itself, with no data ID, without changing the existing behavior when omitting--idor using it with a string argument.