DM-21919: Run ap_verify end-to-end in Gen 3 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
Aug 6, 2020
This brings alert handling in line with database and config handling.
SimonKrughoff
approved these changes
Aug 17, 2020
| # - location: $AP_VERIFY_DIR/pipelines/MetricsKpm.yaml # Currently empty, therefore invalid | ||
| - location: $AP_VERIFY_DIR/pipelines/MetricsRuntime.yaml | ||
| - location: $AP_VERIFY_DIR/pipelines/MetricsMisc.yaml | ||
| tasks: |
There was a problem hiding this comment.
In writing pipelines I've been either writing meta pipelines with only inherits blocks or pipelines with only tasks blocks. I agree, in this case, that having the two mixed makes sense.
There was a problem hiding this comment.
So are you saying you would create an ApPipeForApVerify.yaml that does the config override, then import it in ApVerify.yaml in place of the original ApPipe.yaml?
How ap_verify handles pipelines is likely to get cargo-culted by other AP and/or metrics users, so it's worth thinking about whether it's doing things "right".
These pipelines chain the AP pipeline with packages of metrics. These are equivalent to the metrics defined in the config/ directory.
This driver mostly delegates to the pipetask application, but with a few customizations to use ap_verify infrastructure.
This mode calls the existing wrappers for Gen 3 ingestion and Gen 3 pipeline execution. The documentation has been updated to reflect Gen 3 behavior.
This lets users customize the metrics they are running in Gen 3, much as they can in Gen 2.
kfindeisen
force-pushed
the
tickets/DM-21919
branch
from
685e26e
to
7d89571
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the ability to run
ap_verifyentirely in Gen 3. This is a preliminary implementation designed to get something working in CI; see Jira for a list of ticketed improvements.This PR is relative to
tickets/DM-26070to make it easy to see what is changing on this ticket; it must not be merged tomasterbefore #96.