Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-21915: Support Gen 3 ingestion of ap_verify datasets #11

Merged
merged 2 commits into from Jul 14, 2020
Merged

DM-21915: Support Gen 3 ingestion of ap_verify datasets #11

merged 2 commits into from Jul 14, 2020

Conversation

kfindeisen
Copy link
Member

This PR updates the Gen 3 repository in this dataset to match the current weekly.

@kfindeisen kfindeisen requested a review from TallJimbo July 9, 2020 23:39
TallJimbo
TallJimbo approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like adding a bit of sorting or other determinism to the export mechanism might have avoided some churn here. Something for @timj and I to think about.

@timj
Copy link
Member

timj commented Jul 10, 2020

I saw that. I wonder where the randomness is coming from. It's a list that got reordered.

@kfindeisen kfindeisen merged commit 66db125 into master Jul 14, 2020
@kfindeisen kfindeisen deleted the tickets/DM-21915 branch July 14, 2020 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallJimbo TallJimbo TallJimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kfindeisen @timj @TallJimbo