Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM- 26629: switch to calibration collections instead of the calibration_label dimension #17

Merged
merged 3 commits into from Sep 26, 2020
Merged

DM- 26629: switch to calibration collections instead of the calibration_label dimension #17

merged 3 commits into from Sep 26, 2020

Conversation

TallJimbo
Copy link
Member

No description provided.

kfindeisen
kfindeisen approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@kfindeisen kfindeisen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One style comment.

There wasn't a good place to ask this as a line comment, but can you double-check the readme and make sure it's still an accurate description of the input files' provenance?

scripts/add_gen3_repo.py Outdated Show resolved Hide resolved
@TallJimbo
Copy link
Member Author

@kfindeisen, good thinking on the README; it was indeed no longer accurate, and I've now updated it. It looks to me like no one is updating testdata_lsst regularly, and when I get a spare moment I'll see if I can figure out whether we should just retire it. But at least right now it doesn't look like it's serving as a very good reference for the contents of ap_verify_testdata.

@TallJimbo TallJimbo merged commit 472c1ef into master Sep 26, 2020
@TallJimbo TallJimbo deleted the tickets/DM-26629 branch September 26, 2020 05:15
@kfindeisen kfindeisen mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfindeisen kfindeisen kfindeisen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TallJimbo @kfindeisen