Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-14557: Add package docs to datasets #2

Merged
merged 2 commits into from Jun 19, 2018
Merged

Conversation

kfindeisen
Copy link
Member

This PR adds documentation for the test dataset (although it is not linked to from anywhere, as this dataset was not meant to be user-visible).

@kfindeisen kfindeisen requested a review from mrawls June 11, 2018 22:42

The dataset contents include raw images, biases, flats, and defects.
The dataset does not provide any templates.
It does have a small Gaia DR1 reference catalog, but it is not guaranteed to overlap with the footprint of the raw data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the refcat doesn't overlap with the raw data... what is the point? (I'm not overly worried about this. It's just weird.) As in the other PR, please elaborate something like templates --> "templates for difference imaging"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It lets us test refcat handling and "ingestion".

I'd love to have a more relevant refcat, but I don't know how to do that. For now this is just the same file that lived in ap_verify_dataset_template.

@kfindeisen kfindeisen merged commit 0e1bc66 into master Jun 19, 2018
@kfindeisen kfindeisen deleted the tickets/DM-14557 branch September 12, 2018 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants