DM-24844: Migrate ap_verify_testdata to obs_lsst #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've kept the dummy Gaia catalog, since it's not observatory-specific.
kfindeisen
force-pushed
the
tickets/DM-24844
branch
from
6b89262
to
e8b6a03
Compare
parejkoj
reviewed
Jun 4, 2020
kfindeisen
force-pushed
the
tickets/DM-24844
branch
from
e8b6a03
to
7efb9ba
Compare
The repository passes basic consistency checks but, like the rest of testdata, is not guaranteed to be useful for analysis.
kfindeisen
force-pushed
the
tickets/DM-24844
branch
from
7efb9ba
to
82a583e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old
obs_testfiles wholesale, replacing them with files fromtestdata_lsstand processed runs onlsst-dev. As before, this repository does not quite conform to theap_verifydataset format; in particular, there are no templates and the data may or may not work together.Aside from data and docs, the only other change is a modified copy of
add_gen3_repo.py. This version of the script hard-codes the test dataset (which is inaccessible to normal use ofDataset) and removes all code for dealing with templates.