Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-16292: Support merging of headers after sorting into date order #12

Merged
merged 11 commits into from Mar 19, 2019

Conversation

timj
Copy link
Member

@timj timj commented Feb 15, 2019

No description provided.

@timj timj force-pushed the tickets/DM-16292 branch 2 times, most recently from 1ca0838 to e0c6c7e Compare February 15, 2019 22:13
Copy link
Contributor

@SimonKrughoff SimonKrughoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I have a few mainly editorial comments.

python/astro_metadata_translator/headers.py Outdated Show resolved Hide resolved
python/astro_metadata_translator/headers.py Outdated Show resolved Hide resolved
python/astro_metadata_translator/headers.py Outdated Show resolved Hide resolved
python/astro_metadata_translator/headers.py Outdated Show resolved Hide resolved
python/astro_metadata_translator/translators/fits.py Outdated Show resolved Hide resolved
python/astro_metadata_translator/headers.py Outdated Show resolved Hide resolved
python/astro_metadata_translator/headers.py Show resolved Hide resolved
python/astro_metadata_translator/headers.py Show resolved Hide resolved
python/astro_metadata_translator/observationGroup.py Outdated Show resolved Hide resolved
python/astro_metadata_translator/translators/fits.py Outdated Show resolved Hide resolved
@timj timj merged commit 6e72ed3 into master Mar 19, 2019
@timj timj deleted the tickets/DM-16292 branch March 19, 2019 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants