Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-17978: Cast to int if required and add casting tests #13

Merged
merged 5 commits into from Feb 20, 2019

Conversation

timj
Copy link
Member

@timj timj commented Feb 19, 2019

Previously casts were in place for str and float but int was
missing.

Copy link
Contributor

@SimonKrughoff SimonKrughoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One comment.

tests/test_translation.py Show resolved Hide resolved
Previously casts were in place for str and float but int was
missing.
* Header dump now debug level
* Warning no longer as confusingly ERROR based
@timj timj merged commit e4a94b1 into master Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants