DM-18576: Warn if translation methods are shadowing others #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows people to work out which class triggered the automated method creation.
SimonKrughoff
approved these changes
Mar 21, 2019
| Raises | ||
| ------ | ||
| AttributeError | ||
| Raised if the named method is not defined by this class. |
There was a problem hiding this comment.
I'm confused here. It states just above that it returns False if the method is not defined.
Sorry, I see now. If it is not specified in this class specifically, an exception is raised.
| @classmethod | ||
| def defined_in_class(cls, name): | ||
| """Report if the specified method name is defined in this class | ||
| or in a base class. |
There was a problem hiding this comment.
I got tripped up with the wording here. You mean "defined in this class specifically, or instead is defined in one of the classes this class inherits from".
| ------- | ||
| in_class : `bool` | ||
| `True` if there is a method of that name defined in this subclass. | ||
| `False` if the method is not defined in this specific subclass. |
There was a problem hiding this comment.
But is defined in one of the classes this class inherits from.
|
|
||
| for name in both: | ||
| if cls.defined_in_class(f"to_{name}"): | ||
| # Must be trivial or constant and constant overrides |
There was a problem hiding this comment.
This grammar doesn't make a ton of sense to me.
…asses A check is made to see if the method has been defined explicitly in the code before creating a trivial/const version. For this to work properly also needed to prevent parent class definitions of _const_map and _trivial_map from appearing in the class if they weren't explicitly nulled by the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to define a translation method in const_map, trivial_map and explicitly via
def. Now warn if that is happening. Also if a class was not overriding the trivial/const maps they would get versions from the parent class which could conceivably override the explicit versions in the child. This now does not happen.