DM-19188: Add support for pre-translation header correction #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertLuptonTheGood
approved these changes
Apr 11, 2019
|
|
||
| from .translator import MetadataTranslator | ||
| from .translators import FitsTranslator | ||
|
|
||
| log = logging.getLogger(__name__) | ||
|
|
||
| ENV_VAR_NAME = "METADATA_CORRECTIONS_PATH" | ||
| """Name of environment variable containing search path for header fix up.""" | ||
|
|
There was a problem hiding this comment.
Why is this set as an environment variable? I was expecting it to be in a known place relative to obs_lsst
There was a problem hiding this comment.
There are three ways to find correction files:
- Pass in explicit search path.
- Read a path from an environment variable.
- Ask the translator class for explicit searchpaths.
Option 3 is how LSST works. See the lsst/obs_lsst#97 PR where I add a search_paths method that specified $OBS_LSST_DIR/corrections be used for the path.
| It is also required that the ``observation_id`` and ``instrument`` | ||
| be calculable prior to header fix up. | ||
|
|
||
| Correction files use names of the form ``instrument_obsid.yaml``. |
There was a problem hiding this comment.
I think it'd be helpful to provide a complete example of a filename here
Corrections are applied by locating YAML files named after the instrument/observation_id.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrections are applied by locating YAML files named after the instrument/observation_id.