DM-19766: Fix DECam translation problem and add date consistency tests #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the exposure time to calculate the end date.
UT is documented to mean the middle of the exposure although in the test headers available it has the same value as UT-STR.
Sometimes the headers are a bit inconsistent and the end time is a fraction of a second before the exposure time would suggest.
* Is the start date <= end date? * Is the end date >= start date + exposure time
timj
changed the title
SimonKrughoff
approved these changes
May 23, 2019
| datetime_begin = self.to_datetime_begin() | ||
| exposure_end = datetime_begin + exposure_time | ||
| if value < exposure_end: | ||
| value = exposure_end |
There was a problem hiding this comment.
Shouldn't this be an error, or is it actually expected?
There was a problem hiding this comment.
There seems to be a problem with Suprimecam data where the end time in the header is less than the start time plus the exposure time. I don't have enough suprimecam data to know if that's always true so this test is there to ensure that the the latest end time is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.