DM-20073: Add makeObservationInfo #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an extra element to each entry defining a property. The extra element is the actual Python type expected for the property. This allows for the translated properties to be checked to ensure they have the right type. I considered trying to derive the class name from the current class string (or using the type, derive the fully qualified name) but it was easier to have the string form and the python type explicitly at the risk of some duplication and downstream breakage for people that define their own properties. The third element can be anything that can be passed to isinstance().
This is not generally a useful thing to do because there is no facility yet to assign properties after construction.
This lets someone create an ObservationInfo directly from keyword/value pairs. The values are validated.
makeObservationInfo seems like a better name to me than make_obs_info given that it really is a constructor for ObservationInfo.
isullivan
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get validation working I've had to also add an extra element to the PROPERTIES definitions to allow for the supplied values to be vetted to ensure they are the correct class.
@Cadair does this affect you?