DM-20169: Simplify default search path for fix_header #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now a translator can set a class attribute with the location and it will be picked up by the bsae class implementation of translator.search_path(). Add tests for this and stub directories for other translator fixup files.
If the header is unrecognized by the system we return without modifying it. This lets generic code request fixups without requiring that the calling code knows if the header is understood.
SimonKrughoff
approved these changes
Jun 17, 2019
| @@ -207,9 +208,6 @@ def fix_header(header, search_path=None, translator_class=None, filename=None): | |||
|
|
|||
| Raises | |||
| ------ | |||
There was a problem hiding this comment.
Doesn't it still raise a ValueError?
| @@ -0,0 +1 @@ | |||
| DETECTOR: NEW-ID | |||
There was a problem hiding this comment.
I thought we had agreed (maybe just by convention) that detector ids were integers.
There was a problem hiding this comment.
This value is something for me to use in a test of header fixing. It's not being used in metadata translation at all -- I am checking that when a try to fix a header that purports to have this OBSID, that the detector header is replaced with that value.
There was a problem hiding this comment.
Also, in DECam the DETECTOR header refers to the detector serial. It's not the detector name or number.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now a translator can set a class attribute with the location and it will be picked up by the bsae class implementation of
translator.search_path().Add tests for this and stub directories for other translator fixup files.