DM-16297: (take 2) Remove PropertyList hack #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that PropertySet supports __getitem__ and update there is no need to convert them to OrderedDict before using the headers. For merging this now means that if you request to merge some PropertyList headers you get back a PropertyList (which is critical if you then want to pass the result to afw) Still have to copy the input list since it is modified in place.
timj
force-pushed
the
tickets/DM-16297
branch
from
a2ad266
to
d2fd0d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that PropertySet supports getitem and update there
is no need to convert them to OrderedDict before merging.
This now means that if you request to merge some PropertyList
headers you get back a PropertyList (which is critical if
you then want to pass the result to afw)
Still have to copy the input list since it is modified
in place.