DM-21212: Update existing cp_pipe tasks to pipelineTasks #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
Dec 4, 2019
czwa
force-pushed
the
tickets/DM-21212
branch
from
b32ddf5
to
86195c1
Compare
czwa
force-pushed
the
tickets/DM-21212
branch
2 times, most recently
from
56ca438
to
eb5dec5
Compare
czwa
force-pushed
the
tickets/DM-21212
branch
from
eb5dec5
to
6cfdc43
Compare
The restriction that only science data receive visits is unneeded.
czwa
force-pushed
the
tickets/DM-21212
branch
from
6cfdc43
to
cab1ac4
Compare
|
I'm fine with this being merged at some point rather than making you continually rebase. I think we all agree it's fine regardless of the rest of DM-21212. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
visit_id should be populated for all Subaru data.
The restriction that only science data receive visits is unneeded. Without this, calibration data cannot be processed by ip_isr.