DM-22576: Programmatic header fixups #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-22576
branch
from
7e697d2
to
c7565e5
Compare
PaulPrice
approved these changes
Dec 12, 2019
|
|
||
| @classmethod | ||
| def fix_header(cls, header): | ||
| header["DTSITE"] = "hi" |
There was a problem hiding this comment.
Just curious: what is DTSITE supposed to refer to?
There was a problem hiding this comment.
It's a header I picked at random from the test header that was being used. It has a value of "ct" in the header and I was checking that this callback triggered and changed it to "hi".
The file and resource checks are now private functions.
It's possible that some headers are so broken that the code trying to fix them up can't work out something. A date is a good example since an error parsing a date in a header will cause many date-based corrections to fail. Log the problem and hope that a file-based correction is put in place that allows the translator code to function properly.
timj
force-pushed
the
tickets/DM-22576
branch
from
c7565e5
to
62eb9fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.