DM-29218: Add provenance to header fix up #50
Conversation
Adds some new keys indicating that the fixup was done and the version of the software that did it.
| return modified or translator_modified | ||
| was_modified = (corrections_file is not None) or translator_modified | ||
|
|
||
| # Always add a sentinel even if we nothing was updated |
There was a problem hiding this comment.
I understand the desire to save a little time by not re-scanning, but adding cards (even ones with a deliberately obscure names) seems confusing.
There was a problem hiding this comment.
Are you against the entire concept of this ticket or against adding provenance when the check decided that nothing was needed? Assuming the latter, I was on the fence a bit. On the one hand a new version of metadata fixup would now refuse to fix the header even if it was supposed to (although we could overcome that by checking the value of the MODIFIED header and continue if it was False and the versions differed). On the other hand this does at least record which version of the software decided that no fix up was required.
There was a problem hiding this comment.
Oh, just adding a key when it wasn't modified. But I don't feel strongly.
Adds some new keys indicating that the fixup was done
and the version of the software that did it.