Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-29266: Add translator methods to read all relevant HDUs #52

Merged
merged 15 commits into from
Mar 23, 2021
Merged

DM-29266: Add translator methods to read all relevant HDUs #52

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
332fea3
Clean up some defaults and imports
timj Mar 19, 2021
e22ea05
Add translator method for reading all headers from a file
timj Mar 19, 2021
bc936d4
Change astrometadata translate to use native header reading
timj Mar 19, 2021
7272ce6
Remove file that was added by mistake.
timj Mar 19, 2021
92f2be6
Improve some error messages by including the filename
timj Mar 19, 2021
07e44b3
If the file is not readable but we have primary return it
timj Mar 19, 2021
75a9f85
Adjust test for raise in different place
timj Mar 19, 2021
9edaeec
Only merge by default if hdu num is negative
timj Mar 19, 2021
9dbe240
For default translator reader, merge primary and secondary headers
timj Mar 22, 2021
b7698cc
Rename read_all_headers and improve documentation for it
timj Mar 23, 2021
910c337
Add comment about CCDNUM
timj Mar 23, 2021
cfd962d
Remove EXTNAME setting for MegaPrime
timj Mar 23, 2021
ffc1237
Special case YAML metadata files
timj Mar 23, 2021
b44353c
Note the default hdrnum is negative for astrometadata translate
timj Mar 23, 2021
50343bc
Make some improvements to documentation
timj Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions python/astro_metadata_translator/file_helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
import sys
import traceback

from astro_metadata_translator import merge_headers, ObservationInfo
from .headers import merge_headers
from .observationInfo import ObservationInfo
from .tests import read_test_file


Expand Down Expand Up @@ -111,7 +112,7 @@ def find_files(files, regex):
return found_files


def read_basic_metadata_from_file(file, hdrnum, errstream=sys.stderr, can_raise=False):
def read_basic_metadata_from_file(file, hdrnum, errstream=sys.stderr, can_raise=True):
timj marked this conversation as resolved.
Show resolved Hide resolved
"""Read a raw header from a file, merging if necessary

Parameters
Expand All @@ -126,7 +127,7 @@ def read_basic_metadata_from_file(file, hdrnum, errstream=sys.stderr, can_raise=
Stream to send messages that would normally be sent to standard
error. Defaults to `sys.stderr`. Only used if exceptions are disabled.
can_raise : `bool`, optional
Indicate whether the function can raise and exception (default)
Indicate whether the function can raise an exception (default)
or should return `None` on error. Can still raise if an unexpected
error is encountered.

Expand Down