-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-29266: Add translator methods to read all relevant HDUs #52
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
332fea3
Clean up some defaults and imports
timj e22ea05
Add translator method for reading all headers from a file
timj bc936d4
Change astrometadata translate to use native header reading
timj 7272ce6
Remove file that was added by mistake.
timj 92f2be6
Improve some error messages by including the filename
timj 07e44b3
If the file is not readable but we have primary return it
timj 75a9f85
Adjust test for raise in different place
timj 9edaeec
Only merge by default if hdu num is negative
timj 9dbe240
For default translator reader, merge primary and secondary headers
timj b7698cc
Rename read_all_headers and improve documentation for it
timj 910c337
Add comment about CCDNUM
timj cfd962d
Remove EXTNAME setting for MegaPrime
timj ffc1237
Special case YAML metadata files
timj b44353c
Note the default hdrnum is negative for astrometadata translate
timj 50343bc
Make some improvements to documentation
timj File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 , this is much clearer than the original wording.