DM-34331: Use black/isort #56
Conversation
timj
force-pushed
the
tickets/DM-34331
branch
3 times, most recently
from
bc87943
to
ef9952e
Compare
timj
force-pushed
the
tickets/DM-34331
branch
2 times, most recently
from
491a782
to
b334c69
Compare
Codecov Report
@@ Coverage Diff @@
## main #56 +/- ##
=======================================
Coverage ? 77.79%
=======================================
Files ? 36
Lines ? 2968
Branches ? 471
=======================================
Hits ? 2309
Misses ? 542
Partials ? 117 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I wonder if you can add type hints for dynamic properties by setting the __annotations__ class variable when you set up the properties?
That might also allow you to do something with the extension properties. Does mypy complain when running test_extensions.py?
| altaz_begin: astropy.coordinates.AltAz | ||
| science_program: str | ||
| observation_type: str | ||
| observation_id: str |
There was a problem hiding this comment.
I wonder if you can do this by adding the types to ObservationInfo.__annotations__ when the properties are created?
There was a problem hiding this comment.
I'm fairly certain that mypy does not support __annotations__ because it does not actually run the python code.
There was a problem hiding this comment.
@TallJimbo do you have any thoughts on this question as to whether it's possibly for mypy to derive properties?
There was a problem hiding this comment.
Maybe there's some way to do it via a MyPy plugin, but I'm pretty sure there's nothing you can do short of that that isn't equivalent to what you've done here.
| to_altaz_begin: Callable[[MetadataTranslator], astropy.coordinates.AltAz] | ||
| to_science_program: Callable[[MetadataTranslator], str] | ||
| to_observation_type: Callable[[MetadataTranslator], str] | ||
| to_observation_id: Callable[[MetadataTranslator], str] |
mypy needs them because this helper class does not inherit from unittest.TestCase.
MetadataTranslator and ObservationInfo have dynamic properties but that works against mypy. Declare the standard set so that mypy does not complain about its own code.
No description provided.