New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-35047: Add upload to pypi #59
Conversation
Codecov Report
@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 78.12% 78.44% +0.31%
==========================================
Files 36 36
Lines 3045 3085 +40
Branches 476 549 +73
==========================================
+ Hits 2379 2420 +41
+ Misses 548 543 -5
- Partials 118 122 +4
Continue to review full report at Codecov.
|
@timj this the last one left to close out the ticket. Matrix build is handled in DM-35191. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package needs to be changed to use the lsst_versions system for determining version number. It currently does not use it and has relied on manual tags (and manual releases). Switching this to automatic upload will require that we determine the version from git.
@ktlim I had intended this package to use semantic versioning but given I haven't made a release to PyPI in 3 years it's probably best to give up on that idea and go with the pipelines version number. If we want to stick to semantic version we could change the tag pattern match and switch to setuptools_scm.
31f5422
to
0182ab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks.
0182ab7
to
dfed9ae
Compare
No description provided.