Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-35047: Add upload to pypi #59

Merged
merged 1 commit into from Jun 17, 2022
Merged

DM-35047: Add upload to pypi #59

merged 1 commit into from Jun 17, 2022

Conversation

mwittgen
Copy link
Contributor

No description provided.

@mwittgen mwittgen requested a review from timj June 10, 2022 23:18
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #59 (dfed9ae) into main (ea75cfb) will increase coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   78.12%   78.44%   +0.31%     
==========================================
  Files          36       36              
  Lines        3045     3085      +40     
  Branches      476      549      +73     
==========================================
+ Hits         2379     2420      +41     
+ Misses        548      543       -5     
- Partials      118      122       +4     
Impacted Files Coverage Δ
python/astro_metadata_translator/properties.py 100.00% <0.00%> (ø)
python/astro_metadata_translator/file_helpers.py 73.39% <0.00%> (ø)
tests/test_extensions.py 96.15% <0.00%> (+0.07%) ⬆️
python/astro_metadata_translator/headers.py 93.58% <0.00%> (+0.10%) ⬆️
python/astro_metadata_translator/indexing.py 70.37% <0.00%> (+0.22%) ⬆️
...thon/astro_metadata_translator/observationGroup.py 81.57% <0.00%> (+0.24%) ⬆️
...thon/astro_metadata_translator/translators/sdss.py 81.55% <0.00%> (+0.55%) ⬆️
...hon/astro_metadata_translator/translators/decam.py 72.79% <0.00%> (+0.61%) ⬆️
...astro_metadata_translator/translators/megaprime.py 75.51% <0.00%> (+0.77%) ⬆️
...stro_metadata_translator/translators/suprimecam.py 82.88% <0.00%> (+0.80%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea75cfb...dfed9ae. Read the comment docs.

@mwittgen
Copy link
Contributor Author

@timj this the last one left to close out the ticket. Matrix build is handled in DM-35191.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package needs to be changed to use the lsst_versions system for determining version number. It currently does not use it and has relied on manual tags (and manual releases). Switching this to automatic upload will require that we determine the version from git.

@ktlim I had intended this package to use semantic versioning but given I haven't made a release to PyPI in 3 years it's probably best to give up on that idea and go with the pipelines version number. If we want to stick to semantic version we could change the tag pattern match and switch to setuptools_scm.

setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Show resolved Hide resolved
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks.

.github/workflows/build.yaml Outdated Show resolved Hide resolved
@mwittgen mwittgen merged commit b701ae6 into main Jun 17, 2022
@mwittgen mwittgen deleted the tickets/DM-35047 branch June 17, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants