DM-36086: Make pedantic=False more accepting #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With pedantic=False we should be catching all exceptions from individual translations, not just those associated with missing keys.
Codecov ReportBase: 78.53% // Head: 78.25% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
- Coverage 78.53% 78.25% -0.29%
==========================================
Files 36 36
Lines 3103 3067 -36
Branches 550 476 -74
==========================================
- Hits 2437 2400 -37
- Misses 544 549 +5
+ Partials 122 118 -4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
timj
force-pushed
the
tickets/DM-36086
branch
2 times, most recently
from
ab7208a
to
4ae079c
Compare
mwittgen
approved these changes
Sep 13, 2022
pyproject.toml
Outdated
| @@ -2,13 +2,110 @@ | |||
| requires = ["lsst-versions"] | |||
There was a problem hiding this comment.
We had this pinned lsst_versions > 1.3.0in other repos but that shouldn't be necessary
timj
force-pushed
the
tickets/DM-36086
branch
from
46fa60b
to
94f975c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch all translation exceptions, not just KeyError.