DM-10496 test_chebyMap.py sometimes segfaults #13
Conversation
tests/test_chebyMap.py
Outdated
| lbnd_i = [-3.0] | ||
| ubnd_i = [-1.0] | ||
|
|
||
| for i in range(1000): |
There was a problem hiding this comment.
I'm assuming the for loop here is to ensure that you trigger the segfault? Please document it as such, otherwise it's confusing why there's an un-used iterator in a loop here.
Also, please lift the assert into the loop (might as well check each of the returns, incase the bug manifests itself as data corruption instead of a segfault).
There was a problem hiding this comment.
Yes to both. Note: I originally had the assert in the loop, but found it greatly reduced the odds of a segfault, so I moved it out. However, I then found that creating amap in the loop greatly increased the odds of a segfault. It turns out that this remains so even with the assert in the loop, so I moved the assert back into the loop as you requested.
tests/test_polyMap.py
Outdated
| [-3.6, 2, 1], | ||
| ]) | ||
|
|
||
| for i in range(1000): |
There was a problem hiding this comment.
Please document why there's a big for loop here, and lift the assert into the loop (might as well check each of the returns, incase the bug manifests itself as data corruption instead of a segfault).
...one for PolyMap, one for ChebyMap.
No description provided.