Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-10485: Protected methods should not use private method naming convention #16

Merged
merged 3 commits into from
May 19, 2017
Merged

DM-10485: Protected methods should not use private method naming convention #16

merged 3 commits into from
May 19, 2017

Commits on May 19, 2017

  1. Make _basicFromAstObject private in Object 

    There was no reason for it to be protected so make it private.
    @r-owen
    r-owen committed May 19, 2017
    Configuration menu
    Copy the full SHA
    2479ba6 View commit details
    Browse the repository at this point in the history

  2. Make _stream private to Channel 

    and add `isFits` argument to protected constructor.
Thus Channel, not FitsChan calls stream.setIsFits
so change the friend class in Stream.
    @r-owen
    r-owen committed May 19, 2017
    Configuration menu
    Copy the full SHA
    1b6e4d8 View commit details
    Browse the repository at this point in the history

  3. No underscore on protected names 

    Change the names of protected methods and instance
variables to remove the leading underscore.
    @r-owen
    r-owen committed May 19, 2017
    Configuration menu
    Copy the full SHA
    c21c664 View commit details
    Browse the repository at this point in the history