DM-10561: Switch to LSST capitalization and properties in Python #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So NIn instead of Nin, similarly for NOut, NAxes NCard, NFrame.... The one exception is that getID remains as spelled (LSST prefers getId) to reduce pain for users familiar with AST.
“Class” sounds like a C++ class and `class` is not a valid property name in Python Also change Object.__repr__ to not be a full dump, as it is too annoying.
The argument was an int whose value was 1 for lon, 2 for lat; I changed it to a bool.
Two versions of `getSkyRef` and `getSkyRefP` were wrapped but only one of each actually exists.
Instead of having to specify cards using 80 characters, `pad` pads the end with spaces, simplifying the test
Use properties instead of setters and getters for scalar values
Document the fact that Object.getNObject and refCount are only for debugging astshim.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So NIn instead of Nin, similarly for NOut, NAxes
NCard, NFrame.... The one exception is that getID
remains as spelled (LSST prefers getId) to reduce pain
for users familiar with AST.