DM-10946: Non-square MatrixMap composed with a ShiftMap cannot be simplified #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
commented
Jun 16, 2017
tests/test_matrixMap.py
Outdated
| [0.0, 1.0, 2.0], | ||
| ], dtype=float) | ||
| pred_outdata = np.array(m1 * indata[0] + m2 * indata[1] + shift) | ||
| pred_outdata.shape = (1, len(indata[0])) |
There was a problem hiding this comment.
This seems really verbose. Why not just trust the unsimplified seriesMap (calling the SeriesMap constructor if needed to guarantee that it hasn't been simplified)?
There was a problem hiding this comment.
I did it this way to make the test as rigorous as possible. I agree it is more than the ticket requires, but I prefer to prove that a map does what it should do when possible. I tried to simplify the code slightly.
Also I realized the code should be in test_cmpMap.py so I moved it there. Then I discovered that was missing tests for Mapping.then and Mapping.under so I added those (as very simple additions to the existing test cases, with minor associated cleanup).
Test that a non-square matrix map followed by a shift map can be simplified and performs as expected.
test_cmpMap.py should have been testing `Mapping.from` and `Mapping.under` but was not doing so. Add tests as simple additions to the existing test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that a non-square matrix map followed by a shift map can be simplified and performs as expected.