DM-11454: Modify UnitNormMap to round trip zero-length vectors #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
approved these changes
Aug 1, 2017
tests/test_unitNormMap.py
Outdated
| [7.0, -23.0, -3.0, 45.0, 0.0], | ||
| [fullCenter[0], 1.0, 2.0, -6.0, 30.0, 1.0], | ||
| [fullCenter[1], 3.0, 99.0, -5.0, 21.0, 0.0], | ||
| [fullCenter[2], -5.0, 3.0, -7.0, 37.0, 0.0], | ||
| ], dtype=float)[0:nin] |
There was a problem hiding this comment.
This is kind of hard to follow. Maybe move fullCenter and fullIndata (?) outside the loop, to make it clearer that each iteration only needs a subset?
tests/test_unitNormMap.py
Outdated
| ], dtype=float)[0:nin] | ||
| self.checkRoundTrip(unitnormmap, indata) | ||
|
|
||
| outdata = unitnormmap.applyForward(indata) | ||
| norm = outdata[-1] | ||
|
|
||
| # the first input point is at the center, so the expected output | ||
| # [Nan, Nan, ..., Nan, 0] | ||
| pred_out_at_center = [np.nan] * nin |
There was a problem hiding this comment.
Try to be consistent in your naming style; I see a mixture of camel-case, underscores, and undelimited names for variables.
Ehnance unit test of UnitNormMap to test transforming position = center.
r-owen
force-pushed
the
tickets/DM-11454
branch
from
e22f29a
to
49c7edf
Compare
PolyTran has changed and this broke a test that expected equality; checking that the results are close is good enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ehnance unit test of UnitNormMap to test transforming position = center.