DM-11895: Support getting data for current card of FitsChan #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The descriptions of the coefficient matrices for PolyMap and ChebyMap were not internally consistent. I rewrote the text to make it clearer.
The former had no documentation. The latter had documentation, but it was not visible to Doxygen.
r-owen
force-pushed
the
tickets/DM-11895
branch
from
254c0e1
to
2e3f433
Compare
...if the name is blank, and make the default name blank. Note: I tried using a pointer to a std::string but that broke the Python wrapper due to a bug in pybind11 (reported). Do the same for FitsChan.testFits (a new AST feature). Enhance test_fitsChan.py to test this new capability. Also enhance the unit test to test all fitsSet<X> and fitsGet<X> and to test behavior for a non-existent card.
also improve markup for "name" parameter
Add .cache and pytest_session.txt to .gitignore
This eliminates one set of warnings in the unit tests, leaving 4 warnings from numpy: `RuntimeWarning: invalid value encountered in true_divide`
r-owen
force-pushed
the
tickets/DM-11895
branch
from
7a30e93
to
7dcc60c
Compare
Use `import astshim as ast` in Python as best practice, so the Python looks more like the C++, which uses namespace `ast`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.