DM-11791: Fix memory leak in isSeries #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They had not been updated for the change in axis order for applyForward and applyInverse
and Mapping.then, Mapping.under and Frame.under to indicate that the returned mapping contains shallow copies of the input mappings.
Expand the testing of shallow and deep copying and deleting AST objects when done with them. Expand the test of FrameSet to more thoroughly test FrameSet.getMapping and FrameSet.remap.
It turns out FrameSet.remapFrame used a shallow copy of the frame; for better consistency with FrameSet.addFrame, etc., I changed this to make a deep copy, and updated the unit test accordingly.
timj
commented
Sep 23, 2017
| @@ -97,6 +97,10 @@ class CmpMap : public Mapping { | |||
| bool getSeries() { return detail::isSeries(reinterpret_cast<AstCmpMap *>(getRawPtr())); } | |||
|
|
|||
| protected: | |||
| virtual std::shared_ptr<Object> copyPolymorphic() const override { | |||
There was a problem hiding this comment.
Add a comment string saying what this is?
There was a problem hiding this comment.
Every single subclass of Object has one of these and it is documented there as something each subclass must override. I'm reluctant to add this to all subclasses on this ticket but will file a new one if you like. Doxygen already copies the docs.
There was a problem hiding this comment.
The reason I managed to miss this is that Mapping defines it. I wonder if I should eliminate that and copy, since Mapping is an abstract class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.