Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-12611: FrameDict(FrameSet const &) broken #34

Merged
merged 5 commits into from
Nov 14, 2017
Merged

DM-12611: FrameDict(FrameSet const &) broken #34

merged 5 commits into from
Nov 14, 2017

Commits on Nov 14, 2017

  1. Add missing include 

    astshim.h did not include FrameDict.h
    @r-owen
    r-owen committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    5faf211 View commit details
    Browse the repository at this point in the history

  2. Fix typo in doc string

    @r-owen
    r-owen committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    657a5f2 View commit details
    Browse the repository at this point in the history

  3. Clean up a FrameDict constructor 

    FrameDict(AstFrameSet*) was needlessly testing that the result was
a FrameSet; it calls the FrameSet(AstFrameSet *) constructor,
which performs the same test.
    @r-owen
    r-owen committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    fdb602c View commit details
    Browse the repository at this point in the history

  4. Add test for FrameDict memory issue 

    In C++ FrameDict(FrameSet const &) resulted in an unusable
FrameDict, as AST had already deallocated the AST pointer.
The pybind11 wrapper for that constructor did not show the problem,
making the bug difficult to test in Python. Add a function that
shows the bug in Python and call it in test_frameDict.py
    @r-owen
    r-owen committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    8bd4c33 View commit details
    Browse the repository at this point in the history

  5. Fix FrameDict memory issue 

    FrameDict(FrameSet const &) constructed an unusable FrameDict because
AST had already deallocated the raw pointer. Fix the constructor.
The test added in the previous commit now passes.
    @r-owen
    r-owen committed Nov 14, 2017
    Configuration menu
    Copy the full SHA
    e01670d View commit details
    Browse the repository at this point in the history