DM-12771: Support the new FitsChan ReplaceSip attribute #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and make carLin a property in the pybind11 wrapper
r-owen
changed the title
parejkoj
reviewed
Nov 20, 2017
| @@ -84,6 +84,47 @@ def insertPixelMapping(self, mapping, frameSet): | |||
| frameSet.addFrame(ast.FrameSet.CURRENT, iwcToSky, skyFrame) | |||
| return frameSet | |||
|
|
|||
| def test_FitsChanAttributes(self): | |||
There was a problem hiding this comment.
I think it would be good to have a docstring here saying that this tests the default values and attributes (which function like python properties, I think?).
r-owen
force-pushed
the
tickets/DM-12771
branch
from
81bc5d0
to
9d07dbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.