Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-13166: Update AST to add support for writing SIP terms #36

Merged
merged 1 commit into from Jan 5, 2018

Conversation

r-owen
Copy link
Contributor

@r-owen r-owen commented Jan 4, 2018

No description provided.

Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.


Use Spitzer Space Telescope keywords to define distortion? (bool)

This attribute is a boolean value which specifies whether to include support for the " SIP" scheme,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space after the quote here.

/**
Set @ref FitsChan_SipOK "SipOK": use Spitzer Space Telescope keywords to define distortion?
*/
void setSipOK(bool replace) { setB("SipOK", replace); }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace is an odd variable name.

@r-owen r-owen merged commit 7d8733b into master Jan 5, 2018
@ktlim ktlim deleted the tickets/DM-13166 branch August 25, 2018 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants